This repository was archived by the owner on Dec 15, 2018. It is now read-only.
Convert node versions return by Travis API to Strings#12
Merged
Conversation
Travis API return the Node version as a String or a Number based on the way it's defined in .travis.yml (node_js: '8' => String / node_js: 8 => Number). `semver` expect a String and consider invalid the versions expressed as a Number Fix #347
geraintwhite
added a commit
to itsapi/github-listener
that referenced
this pull request
Sep 21, 2017
hack is no longer necessary as bug is fixed by [this](semantic-release/travis-deploy-once#12)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis API return the Node version as a String or a Number based on the
way it's defined in .travis.yml (node_js: '8' => String / node_js: 8 =>
Number).
semverexpect a String and consider invalid the versions expressed asa Number
Fixes semantic-release/semantic-release#347