Conversation
shiroyasha
reviewed
Dec 14, 2021
shiroyasha
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--disconnect-after-idle-timeoutargument to shutdown agent after a period of idlenessSEMAPHORE_AGENT_SHUTDOWN_REASONenvironment variable to shutdown hook script. The main reason for this addition is to implement scaling down on agent-aws-stack. When an agent shuts down due to a finished job, we want the autoscaling group to spin up a new agent, so we terminate that instance, but keep the same desired count on the autoscaling group. When an agent shuts down due to idleness, we don't really want the autoscaling group to spin up a new instance, so we terminate the instance and decrement the desired count for the autoscaling group.