Conversation
Merged
shiroyasha
reviewed
Mar 9, 2022
| - name: Install gotestsum | ||
| run: go install gotest.tools/gotestsum@latest | ||
| - name: Test | ||
| run: gotestsum --format short-verbose --packages="./..." -- -p 1 |
shiroyasha
reviewed
Mar 9, 2022
| * UTF8 files without a BOM containing non-ASCII characters may break in Windows PowerShell, | ||
| * since it misinterprets it as being encoded in the legacy "ANSI" codepage. | ||
| * Since we need to support non-ASCII characters, we need a UTF-8 file with a BOM. | ||
| * See: https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_character_encoding |
Contributor
|
Everything is clean. Nice work 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on #144.
ssh_jump_pointone is left)job_log.jsonfiles now use thejob_log_{EpochNanos}.jsonnaming convention to avoid name clashing while testing, and are always removed when the logger is closedtest/support/commands.gofile to help with commands in testing for bash and powershelltest/support/hub.goto mock the hub to which the agent registers and syncstest/support/loghub.goto mock the hub to which the agents pushes logs to