fix: avoid unnecessary Write in FileBackend#159
Merged
lucaspin merged 2 commits intosemaphoreci:masterfrom Aug 5, 2022
Merged
Conversation
Contributor
|
/sem-approve |
2 similar comments
Contributor
|
/sem-approve |
Member
|
/sem-approve |
Contributor
|
@lyoung-confluent nice find, and thanks for the PR. Would you be able to update your branch with the latest master? There was an issue with CI, which led your build to fail. The issue was fixed in #160, so if you pull the latest master into your branch, CI should pass. |
Member
|
/sem-approve |
lucaspin
approved these changes
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was just skimming the code and noticed a minor optimization in
FileBackend. Currently it calls(*os.File).Writetwice, once for the JSON line then to add a\n. Because this is not a bufferedio.Writer(i.e.bufio) this could result in unnecessary write syscalls and resulting disk I/O. Instead you can just append the\nin memory and callWriteonce.