Reprojection logic#2
Closed
alexandreflusin wants to merge 12 commits into
Closed
Conversation
The following is printed when code that includes `np.float` attempts to run: AttributeError: module 'numpy' has no attribute 'float'. `np.float` was a deprecated alias for the builtin `float`. To avoid this error in existing code, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here. The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
Fix issues when using newer versions of matplotlib
|
This PR was supposed to go to NeLy-EPFL/main, not semihgunel/main! This can be closed and Alex can open a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the plot_2d method of the Camera class was used to plot both the 2d video and the 2d part of the 3d video without making being able to re-project the 3d points calculated by triangulation. Because of that, it was plotting the points from 2d pose estimation for both videos. The function was changed so that it can take both 2d and 3d points as argument and then distinguish them based on their dimension. If the argument has 3d points, the method projects them and then plots them. They are transposed when passed in the cv2 functions because those use the (column, row) format