Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 318cdba1ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| samePath(pluginRoot, INSTALLED_PLUGIN_ROOT) && | ||
| process.env.CC_PLUGIN_CODEX_SKILLS_MATERIALIZED !== "1" | ||
| ) { | ||
| materializeInstalledSkillPaths(pluginRoot); |
There was a problem hiding this comment.
Materialize skill placeholders for any local install root
This gate only rewrites SKILL.md placeholders when pluginRoot already equals ~/.codex/plugins/cc, so node scripts/local-plugin-install.mjs install from a normal checkout path skips materialization entirely. In that common flow, plugin/install copies the checkout into Codex’s cache with literal <installed-plugin-root> strings still present, and runtime skills then try to execute node "<installed-plugin-root>/scripts/claude-companion.mjs" ..., which fails because the placeholder was never replaced.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressing this in #27. Rather than mutating arbitrary checkout roots in place, the follow-up makes unsupported direct source-root installs fail fast with a clear message and keeps the supported local-checkout flow explicit.
Summary
Verification