-
Notifications
You must be signed in to change notification settings - Fork 52
chore: Refactored unittest to check for specific repo files to use assert #58
Conversation
|
@mptap I have to apologize, I know you signed the CLA on another of our repos, but our legal team is funny and would like people to sign it for each repo they contribute to. Is that OK? |
|
@mbernier: No worries, I understand :) Signed. |
mbernier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are failing on a line that I don't think exists... https://travis-ci.org/sendgrid/nodejs-http-client/jobs/294205946
Can you please check this and see if there is a typo somewhere?
/home/travis/build/sendgrid/nodejs-http-client/test/test.js:323
Thank you!
|
@mbernier: Whoops, had a missing closing brace, updated. |
|
I merged in the master branch, because I believe most of the files we're checking for exist now :) |
|
@mbernier: Not sure I understand - I don't think this is merged yet. Also, I have signed the CLA. |
|
@mptap due to (kind of silly reasons) each repo requires that you sign the CLA, is that OK? For the merge - I did a merge of the master branch and let it build again, So I could see your code checking the files that other people had added from this list in this issue! |
|
@mbernier: I see. I've signed the CLA for this repo though - when I click on it, it says |
|
I think that it was "stuck" - looks good now. Thank you!! |
|
Hello @mptap, |
Fixes #57
Checklist
Short description of what this PR does:
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.
@mbernier edit - removed extra '#' in title