Skip to content

Add description how install php-http-client manually #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thinkingserious merged 1 commit into from
Oct 11, 2017
Merged

Add description how install php-http-client manually #25

thinkingserious merged 1 commit into from
Oct 11, 2017
+44 −2

Conversation

@janczer
Copy link
Contributor

@janczer janczer commented Oct 5, 2017

According to #20. I added to README.md who install php-http-client without composer.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 5, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 5, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mbernier
mbernier previously requested changes Oct 10, 2017
View reviewed changes
README.md Outdated
$ git clone https://github.com/sendgrid/sendgrid-php.git
```

In the next step you shoud create `loader.php`:
Copy link

@mbernier mbernier Oct 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change "shoud" to "should"

Copy link
Contributor Author

@janczer janczer Oct 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@janczer janczer force-pushed the add_manually_install branch from 1bf3f18 to 481d0cd Compare October 11, 2017 18:53
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 11, 2017
@thinkingserious thinkingserious merged commit 8bff396 into sendgrid:master Oct 11, 2017
@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 11, 2017

Hello @janczer,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@janczer janczer deleted the add_manually_install branch October 11, 2017 19:23
@janczer
Copy link
Contributor Author

janczer commented Oct 11, 2017

Hello @thinkingserious
Thank you, I already filled out form for swag :)

mptap pushed a commit to mptap/php-http-client that referenced this pull request Oct 30, 2018
Add our Developer Experience Engineer career opportunity to the README …
546a2a6 
…sendgrid#25
@mptap mptap mentioned this pull request Oct 30, 2018
Closed
6 tasks
Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
@thinkingserious
Merge pull request sendgrid#25 from janczer/add_manually_install
fab8c5f 
Add description how install php-http-client manually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mbernier mbernier mbernier left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janczer @SendGridDX @thinkingserious @mbernier