Skip to content

Conversation

@goteamtim
Copy link
Contributor

@goteamtim goteamtim commented Oct 21, 2017

Update readme to address #35 and update it like the nodejs README

@mbernier edit: fix #35

Update readme to address sendgrid#35 and update it like the nodejs README
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 21, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 21, 2017

CLA assistant check
All committers have signed the CLA.

README.md Outdated
[![Email Notifications Badge](https://dx.sendgrid.com/badge/php)](https://dx.sendgrid.com/newsletter/php)
[![npm](https://img.shields.io/npm/l/express.svg)]()
[![Twitter Follow](https://img.shields.io/twitter/follow/sendgrid.svg?style=social&label=Follow)](https://twitter.com/sendgrid)
[![GitHub contributors](https://img.shields.io/github/contributors/sendgrid/sendgrid-nodejs.svg)](https://github.com/sendgrid/sendgrid-nodejs/graphs/contributors)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update this to have php-http-client instead of sendgrid-nodejs?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you please remove

+[![npm](https://img.shields.io/npm/l/express.svg)]()

Removed npm link and fixed contributors link
@goteamtim
Copy link
Contributor Author

Hey @mbernier, those changes have been made. Thanks!

@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 24, 2017
@mbernier mbernier merged commit 58215cf into sendgrid:master Oct 24, 2017
@thinkingserious
Copy link
Contributor

Hello @goteamtim,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add/Update Badges on README

4 participants