Skip to content

Conversation

@mptap
Copy link

@mptap mptap commented Oct 30, 2017

Fixes #67

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Added CodeCov support to .travis.yml

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 30, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@b054383). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage          ?   69.44%           
=========================================
  Files             ?        3           
  Lines             ?      108           
  Branches          ?        0           
=========================================
  Hits              ?       75           
  Misses            ?       33           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b054383...0ad98b9. Read the comment docs.

@mbernier mbernier added the difficulty: easy fix is easy in difficulty label Nov 22, 2017
@mbernier mbernier merged commit 3c47713 into sendgrid:master Nov 22, 2017
@thinkingserious
Copy link
Contributor

Hello @mptap,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Fixes sendgrid#67 Add CodeCov support to .travis.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CodeCov support to .travis.yml

5 participants