Skip to content

Conversation

@rvitaliy
Copy link
Contributor

Short description of what this PR does:

  • add phpdoc for send method

add phpdoc for send method
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Feb 13, 2018
@SendGridDX
Copy link

SendGridDX commented Feb 13, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 13, 2018

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files           3        3           
  Lines         170      170           
=======================================
  Hits          148      148           
  Misses         22       22
Impacted Files Coverage Δ
lib/Client.php 84.67% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36693c5...adb06d1. Read the comment docs.

@thinkingserious
Copy link
Contributor

Thanks @rvitaliy!

This is now on our backlog for code review.

With Best Regards,

Elmer

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Feb 28, 2018
@thinkingserious thinkingserious merged commit c83dbeb into sendgrid:master Mar 8, 2018
@thinkingserious
Copy link
Contributor

Hello @rvitaliy,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@rvitaliy rvitaliy deleted the patch-1 branch March 19, 2018 13:15
Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants