Skip to content

Fix #88: Missing Function #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thinkingserious merged 1 commit into from
Mar 9, 2018
Merged

Fix #88: Missing Function #89

thinkingserious merged 1 commit into from
Mar 9, 2018

Conversation

@thinkingserious
Copy link
Contributor

@thinkingserious thinkingserious commented Mar 9, 2018

Fixes #88

Missing function prepareResponse due to bad previous merge.

@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio labels Mar 9, 2018
@codecov
Copy link

codecov bot commented Mar 9, 2018 •
edited
Loading

Codecov Report

Merging #89 into master will decrease coverage by 6.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   87.05%   80.87%   -6.19%     
==========================================
  Files           3        3              
  Lines         170      183      +13     
==========================================
  Hits          148      148              
- Misses         22       35      +13
Impacted Files Coverage Δ
lib/Client.php 77.33% <0%> (-7.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc7138b...301c9f0. Read the comment docs.

@thinkingserious thinkingserious mentioned this pull request Mar 9, 2018
Closed
@thinkingserious thinkingserious merged commit aa4d727 into master Mar 9, 2018
@thinkingserious
Copy link
Contributor Author

thinkingserious commented Mar 9, 2018

Hello @thinkingserious,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

thinkingserious added a commit that referenced this pull request Mar 9, 2018
@thinkingserious
PR #89, Fixes #88 restore prepareResponse function
be17faf
@thinkingserious thinkingserious deleted the 88_add_prepareResponse branch March 10, 2018 00:30
Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
@thinkingserious
Merge pull request sendgrid#89 from sendgrid/88_add_prepareResponse
aefcd77 
Fix sendgrid#88: Missing Function
Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
@thinkingserious
PR sendgrid#89, Fixes sendgrid#88 restore prepareResponse function
37735f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thinkingserious