Skip to content

docs: Added Code Review to Contributing.md #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thinkingserious merged 3 commits into from
Oct 29, 2018
Merged

docs: Added Code Review to Contributing.md #75

thinkingserious merged 3 commits into from
Oct 29, 2018

Conversation

@mptap
Copy link

@mptap mptap commented Oct 31, 2017 •
edited
Loading

Fixes #73

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Added Code Review to Contributing.md

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@mptap mptap mentioned this pull request Oct 31, 2017
Closed
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Mar 6, 2018
jonjenkins
jonjenkins approved these changes Oct 22, 2018
View reviewed changes
Copy link

@jonjenkins jonjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonjenkins jonjenkins added hacktoberfest status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio hacktoberfest labels Oct 22, 2018
@thinkingserious thinkingserious merged commit 9c2630f into sendgrid:master Oct 29, 2018
@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 29, 2018

Hello @mptap,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@sendgrid sendgrid deleted a comment from SendGridDX Oct 29, 2018
@childish-sambino childish-sambino changed the title Added Code Review to Contributing.md docs: Added Code Review to Contributing.md Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonjenkins jonjenkins jonjenkins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Code Review to Contributing.md

4 participants

@mptap @thinkingserious @jonjenkins @mbernier