Skip to content

test: Update unittest removing unnecessary scenarios. #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thinkingserious merged 3 commits into from
Feb 19, 2020
Merged

test: Update unittest removing unnecessary scenarios. #99

thinkingserious merged 3 commits into from
Feb 19, 2020

Conversation

@rafaelverger
Copy link
Contributor

@rafaelverger rafaelverger commented Oct 30, 2018 •
edited
Loading

Fixes

Closes #98

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works

Short description of what this PR does:

Remove testing scenarios that were trying to assert the existence of not existent files.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 30, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious merged commit 9dcc869 into sendgrid:master Feb 19, 2020
@thinkingserious
Copy link
Contributor

thinkingserious commented Feb 19, 2020

Hello @rafaelverger,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@childish-sambino childish-sambino changed the title Update unittest removing unnecessary scenarios. test: Update unittest removing unnecessary scenarios. Feb 19, 2020
@rafaelverger rafaelverger deleted the fix_unittest branch February 25, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

There are tests that probably shouldn't exist

3 participants

@rafaelverger @SendGridDX @thinkingserious