Skip to content

Conversation

@andre8359
Copy link
Contributor

No description provided.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 30, 2017

CLA assistant check
All committers have signed the CLA.

@andre8359 andre8359 force-pushed the develop branch 2 times, most recently from 969f4da to 695b20c Compare October 31, 2017 10:34
@thinkingserious
Copy link
Contributor

@andre8359

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Feb 27, 2018
This was referenced Oct 31, 2018
@misterdorm
Copy link

Duplicated by #55 and #62

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 31, 2018
Copy link

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and address merge conflicts. Thanks!

@andre8359 andre8359 force-pushed the develop branch 2 times, most recently from 6d2e899 to 78a51dd Compare January 11, 2019 11:47
@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@03dcb0a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #53   +/-   ##
=========================================
  Coverage          ?   99.31%           
=========================================
  Files             ?        2           
  Lines             ?      145           
  Branches          ?        0           
=========================================
  Hits              ?      144           
  Misses            ?        1           
  Partials          ?        0
Impacted Files Coverage Δ
smtpapi/__init__.py 98.64% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03dcb0a...18b04fd. Read the comment docs.

Copy link

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andre8359 andre8359 closed this Jan 14, 2019
@andre8359 andre8359 reopened this Jan 14, 2019
@thinkingserious thinkingserious changed the title Fix "similar-code" issue in smtpapi/__init__.py fix: "similar-code" issue in smtpapi/__init__.py Feb 19, 2020
@thinkingserious thinkingserious merged commit de4c5af into sendgrid:master Feb 19, 2020
@thinkingserious
Copy link
Contributor

Hello @andre8359,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants