Conversation
975db98 to
ad74369
Compare
deepdiff/diff.py
Outdated
There was a problem hiding this comment.
@mskhviyu
I wonder if this should be passed to DeepHash or not. When doing deephash calculations, we don't have both of the objects. We have only one of them.
Here in your unit test, if we set the exclude_obj_callback_strict and also ignore_order=True, it should throw and exception since DeepHash does not accept that parameter.
There was a problem hiding this comment.
my mistake, I didn't want to add to deephash. Removed from DEEPHASH_PARAM_KEYS, now my unit test passes successfully with the ignore_order=True parameter
4722bf8 to
0f6cf19
Compare
|
@mskhviyu Thanks for the update. There is one test that is failing: All it needs is this new parameter to be added to |
0f6cf19 to
0f90957
Compare
|
Thanks for the PR @mskhviyu |
Added to deep diff exclude_obj_callback_strict parameter which use AND instead OR