Fix relative screenshot path validation issue #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The load() method now uses os.path.abspath() to convert the filename to an absolute path before extracting the directory. This ensures that screenshot paths are correctly validated relative to the JSON file location, regardless of where the validate, add-game, or add-record commands are called from. Previously, when calling validate with a relative path like './data/records.json', the directory would be extracted as a relative path, which would fail when changing directories for FilePath validation. This fix makes the load() method consistent with the add_record_to_file() method, which already uses os.path.abspath() for the same purpose.
…on versions Added continue-on-error to the coverage check step to prevent workflow failures when the coverage badge changes on Python versions other than 3.12. The badge will still be updated only on Python 3.12 as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.