Fix screenshot path validation issue in add_game_to_file #6
+89
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When add_game_to_file() validated existing records with relative screenshot paths, it would fail because validation occurred from the wrong working directory. This fix ensures the method changes to the JSON file's directory before validation, matching the pattern already used in add_record_to_file(). - Updated add_game_to_file to change working directory before validation - Added test case to reproduce and verify the fix - All existing tests continue to pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When add_game_to_file() validated existing records with relative screenshot paths,
it would fail because validation occurred from the wrong working directory. This fix
ensures the method changes to the JSON file's directory before validation, matching
the pattern already used in add_record_to_file().