Fix some XSS #292
Merged
Fix some XSS #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edulix
force-pushed
the
security-fix-draft-election
branch
2 times, most recently
from
196ede3 to
2fc0e43
Compare
There was an issue with election description. During election creation, we relied in ng-bind-html to sanitize the visualization of election description before being sanitized by the backend (because it has not yet been sent to the backend), but apparently it doesn't work for some xss. The same issue happened in election list when showing the description of the drafti election. With this change, we always show the election description as plain text so that we don't need to sanitize it. Also see related issue with htmlToText in common-ui: sequentech/common-ui#221 because sometimes we also called to our own htmlToText angular filter, and sanitization was also needed to happen there. Another fix is to use $sanitize more pervasively in the election creation screen, so that any reply from the server is also not trusted and properly sanitized.
edulix
force-pushed
the
security-fix-draft-election
branch
from
2fc0e43 to
5348219
Compare
edulix
added a commit
that referenced
this pull request
Jun 16, 2022
There was an issue with election description. During election creation, we relied in ng-bind-html to sanitize the visualization of election description before being sanitized by the backend (because it has not yet been sent to the backend), but apparently it doesn't work for some xss. The same issue happened in election list when showing the description of the drafti election. With this change, we always show the election description as plain text so that we don't need to sanitize it. Also see related issue with htmlToText in common-ui: sequentech/common-ui#221 because sometimes we also called to our own htmlToText angular filter, and sanitization was also needed to happen there. Another fix is to use $sanitize more pervasively in the election creation screen, so that any reply from the server is also not trusted and properly sanitized.
edulix
added a commit
that referenced
this pull request
Jun 16, 2022
There was an issue with election description. During election creation, we relied in ng-bind-html to sanitize the visualization of election description before being sanitized by the backend (because it has not yet been sent to the backend), but apparently it doesn't work for some xss. The same issue happened in election list when showing the description of the drafti election. With this change, we always show the election description as plain text so that we don't need to sanitize it. Also see related issue with htmlToText in common-ui: sequentech/common-ui#221 because sometimes we also called to our own htmlToText angular filter, and sanitization was also needed to happen there. Another fix is to use $sanitize more pervasively in the election creation screen, so that any reply from the server is also not trusted and properly sanitized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with election description. During election creation, we relied in ng-bind-html to sanitize the visualization of election description before being sanitized by the backend (because it has not yet been sent to the backend), but apparently it doesn't work for some xss. The same issue happened in election list when showing the description of the draft election.
With this change, we always show the election description as plain text so that we don't need to sanitize it. Also see related issue with htmlToText in common-ui: sequentech/common-ui#221 because sometimes we also called to our own htmlToText angular filter, and sanitization was also needed to happen there.
Another fix is to use $sanitize more pervasively in the election creation screen, so that any reply from the server is also not trusted and properly sanitized.