Skip to content

Conversation

@Findeton
Copy link
Contributor

@Findeton Findeton commented Jan 2, 2023

Automate filling in election IDs. If the election ID in the Election JSON is negative, replace it with new Election IDs.

Changes

  • Add new method fillInElectionIds. The method detects wether there's any election ID with negative numbers, if there isn't any it returns the election json unmodified.
  • If there is a negative election ID, make a call to the auth api (IAM) to find out the highest existing election ID. Use that to replace the negative election IDs with new election IDs.
  • Call the new method fillInElectionIds after editing the election JSON.

@Findeton Findeton marked this pull request as draft January 2, 2023 09:30
@Findeton Findeton marked this pull request as ready for review January 2, 2023 09:39
@Findeton Findeton requested a review from edulix January 2, 2023 09:39
Copy link
Contributor

@edulix edulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! but please do not merge until reviewed by client.

@Findeton Findeton merged commit 0513860 into master Jan 17, 2023
@Findeton Findeton deleted the id-auto branch January 17, 2023 13:30
Findeton added a commit that referenced this pull request Jan 17, 2023
* wip

* wip

* wip

* wip

* wip

* wip

* parent id

* wip
Findeton added a commit that referenced this pull request Jan 17, 2023
* wip

* wip

* wip

* wip

* wip

* wip

* parent id

* wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants