Some typos :-)

[kmhernan]

Hello, it's Kyle from the BDS user groups. Anyways, thanks for doing this! I have only played with it a little bit but here are about things:

• syntax keyword bdsBoolean true fasle should be syntax keyword bdsBoolean true false
• I find the error and warning types to be a bit annoying because they highlight like a TODO .. I changed them to just keyword types on my end

This is just the first quick look through, but i really appreciate you for starting this!

[serine]

Hi Kyle, I appreciate the feedback. I fixed typos.

For me (molokai colorsheme) Error shows as highlighted with red, whereas Todo shows as bright (bold) white. I changed error and warning to Keyword for now. If that's better for everyone I'm happy to leave it as is.. Pushed to the github.

Cheers

[kmhernan]

Sorry I misspoke. Yes, Error highlighted red, but it was personally annoyed by that. However, that may just be me :). To make some of this easier to manage, perhaps you could start adding in some options. I believe this will make it easier to maintain as more suggestions come in. I made two changes:

• Added the basic helper function from the python-vim people which is very useful when adding options

" Check if option is enabled function
" Adapted from the Python-syntax repository
" Maintained by Dmitry Vasiliev
" <https://github.com/hdima/python-syntax>
function! s:Enabled(name)
  return exists(a:name) && {a:name}
endfunction

• Add a script option bds_error_as_keyword and a function to set it.

" Highlight error and warning keywords as syntax Error or Keyword
" This current assumes the bdsError keywords are interpreted as Error by default
if !s:Enabled("g:bds_error_as_keyword")
  highlight link bdsError Error
else
  highlight link bdsError Keyword
endif

So, assuming that you keep error and warning as Error highlighting types by default (as you originally had it), when you open a bds file you'll get the expected error highlighting (PaperColor-Dark):

However, if you want to view them as keywords, then you can simply change the setting in your ~/.vimrc file:

filetype plugin indent off
syntax on
set ruler
set t_Co=256
colorscheme PaperColor-Dark

" Interpret BDS error/warning command as Keyword instead of Error
let bds_error_as_keyword = 1

And now it highlights as a Keyword:

[kmhernan]

Oh I just saw that some keywords are missing from the bdsTaskIdentifier section. I definitely know that mem should be in there, and I believe that any of the options from the Default Parameters table in the BDS Config File section of the BDS documentation page can be used in task() and dep() commands. We may need to double check with Pablo.

[serine]

Hi Kyle,

Thanks heaps, great suggestion ! thanks for the code snippet too. That's has been implemented and pushed.

As an aside do you know why exists(a:name) && {a:name} ? As in what those brackets checking for and why have two different brackets..?

Also added another line to the syntax highlight mem node queue retry system timeout walltimeout taskShell sysShell all of these highlighted as Identifiers now.

[kmhernan]

Thanks @serine ... So exists(a:name) is checking whether the variable is set (e.g., not null) and {a:name} is equating the boolean true or false .. 1 or 0 ... So basically "if the variable is defined and is true then do stuff"... I'm not an expert on Vim scripting syntax by any means.

[serine]

@kmhernan that makes sense now, thanks.