Skip to content

fix: Added support to IAM role deleteSchedule#628

Closed
geolffreym wants to merge 5 commits intoserverless-operations:masterfrom
geolffreym:master
Closed

fix: Added support to IAM role deleteSchedule#628
geolffreym wants to merge 5 commits intoserverless-operations:masterfrom
geolffreym:master

Conversation

@geolffreym
Copy link
Copy Markdown

fix: #627

@horike37
Copy link
Copy Markdown
Collaborator

horike37 commented Nov 3, 2024

Thank you for this PR. Would you fix the linting error?

@geolffreym
Copy link
Copy Markdown
Author

Thank you for this PR. Would you fix the linting error?

Sure.

@horike37
Copy link
Copy Markdown
Collaborator

@geolffreym
Thank you for fixing the linting errors. Unfortunately, the test has failed. Would you fix it as well?

@VirtueMe
Copy link
Copy Markdown
Collaborator

Hi @geolffreym — thank you for this contribution! The fixes here are solid: parameterising the action, defaulting GroupName to 'default', and conditionally including iam:PassRole only for createSchedule are all the right calls.

However, the recent #711 refactor extracted all per-service IAM logic into separate strategy modules and incorporated all of these fixes in the process:

  • deleteSchedule is now registered in iamStrategies/index.js (line 96)
  • getSchedulerPermissions accepts an action parameter, defaults GroupName to 'default', and conditionally includes iam:PassRole only when Target.RoleArn is present
  • Tests covering all these cases are in iamStrategies/eventbridge.test.js

Your PR is fully superseded by that work, so I'm going to close it to keep the queue clean. Thanks again for identifying and diagnosing the issue — it directly informed how the refactor handled this case.

@VirtueMe VirtueMe closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support EventBridge Scheduler Service deleteSchedule integration

3 participants