fix(stateMachine): handle plain string Fn::Sub when useExactVersion is true#744
Merged
fix(stateMachine): handle plain string Fn::Sub when useExactVersion is true#744
Conversation
…s true
When a state machine uses pseudo-parameters (#{...}) but no lambda
function references, Fn::Sub is set to a plain string rather than
an array. The useExactVersion code path then tried to assign to
index [1] of that string, throwing a TypeError in strict mode.
Fix by converting the plain string form to the array form
[template, {}] before applying the version conversion.
Closes #488
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Cannot assign to read only property '1' of stringthrown duringsls packageuseExactVersion: trueis set and the state machine uses pseudo-parameters (#{}) but has no lambda function referencesFn::Subis a plain string (not an array), and theuseExactVersioncode path tried to assign to index[1]of that string[template, {}]array form before applying the version conversionCloses #488
Test plan
npm testpassesTypeErrorbefore the fix and passes after🤖 Generated with Claude Code