[Fix #677] Atomic produce and consume actions#826
Merged
cdavernas merged 3 commits intoserverlessworkflow:mainfrom Mar 20, 2024
Merged
[Fix #677] Atomic produce and consume actions#826cdavernas merged 3 commits intoserverlessworkflow:mainfrom
cdavernas merged 3 commits intoserverlessworkflow:mainfrom
Conversation
fjtirado
requested review from
antmendoza,
cdavernas,
ricardozanini and
tsurdilo
as code owners
fjtirado
force-pushed
the
Fix_#677
branch
6 times, most recently
from
9021bd7 to
d7aabdc
Compare
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@redhat.com>
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@redhat.com>
fjtirado
commented
Feb 28, 2024
fjtirado
commented
Feb 28, 2024
cdavernas
requested changes
Mar 8, 2024
Member
cdavernas
left a comment
cdavernas
left a comment
There was a problem hiding this comment.
Many thanks for the work! ❤️
Just a couple of pita comments to discuss😄
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@redhat.com>
cdavernas
requested changes
Mar 9, 2024
Member
cdavernas
left a comment
cdavernas
left a comment
There was a problem hiding this comment.
Great work, thank you!
Could I please ask you to update the roadmap.md to include the changes brought by this PR?
cdavernas
requested changes
Mar 9, 2024
Collaborator
Author
This is already there in the roadmap for 0.9 |
Member
@fjtirado You are right! Sorry about that! |
cdavernas
approved these changes
Mar 11, 2024
ricardozanini
approved these changes
Mar 11, 2024
Member
|
Merging this PR as per contribution rules: it has been out for more than 3 weeks, and has already been approved by the required majority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Please specify parts of this PR update:
Discussion or Issue link:
Fixes #677
What this PR does / why we need it:
Separated produceEventRef from consumeEventRef, removing eventRef, and promoting both to first class actions.
Remove kind property from event definition. Therefore the same event definition can be both used for consumption and publishing. if needed.
Special notes for reviewers:
I have couple of doubts about naming notation that I reflected as comments.
Additional information: