Fix usage of endpoint in-call http tasks#877
Merged
ricardozanini merged 5 commits intoserverlessworkflow:mainfrom Jun 3, 2024
Merged
Conversation
matthias-pichler
requested review from
antmendoza,
cdavernas,
ricardozanini and
tsurdilo
as code owners
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
matthias-pichler
force-pushed
the
fix-usage-of-endpoint-in-call-http
branch
from
3249ba3 to
a07afc0
Compare
ricardozanini
approved these changes
Jun 3, 2024
Member
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
Sorry to be a PITA, but can you add an example? I think ours only has this structure:
endpoint:
uri: ...Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Collaborator
Author
no worries ... added an example 👍 |
ricardozanini
requested changes
Jun 3, 2024
Member
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
I think in this case the format is uri-template since we want to support dynamic calls within the task.
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
ricardozanini
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Pichler m.pichler@warrify.com
Please specify parts of this PR update:
Discussion or Issue link:
What this PR does:
The DSL describes the callHttp endpoint property as:
However:
urifield directly in call http tasksso I fixed both
Additional information: