Skip to content

Fix typo RunWokflow#925

Merged
ricardozanini merged 6 commits intoserverlessworkflow:mainfrom
zolero:main
Jul 31, 2024
Merged

Fix typo RunWokflow#925
ricardozanini merged 6 commits intoserverlessworkflow:mainfrom
zolero:main

Conversation

@zolero
Copy link
Contributor

@zolero zolero commented Jul 18, 2024 •
edited
Loading

Fixes typo in Specification

Description:
This pull request fixes a typo in the specification document, correcting "RunWokflow" to "RunWorkflow."

Changes Made:
Corrected the typo "RunWokflow" to "RunWorkflow" in the specification document.

@zolero zolero closed this Jul 18, 2024
@zolero zolero reopened this Jul 18, 2024
@cdavernas
Copy link
Member

cdavernas commented Jul 18, 2024 •
edited
Loading

@zolero Thanks for your PR ❤️
Sorry for being a PITA, but could you describe the PR using the template, for bookkeeping purpose? I know it's just a typo fix, but future users might not have the patience to check changes, and would therefore benefit from a short description 😉
Furthermore, could you be so kind to sign-off your commit?

@zolero
Copy link
Contributor Author

zolero commented Jul 18, 2024

@zolero Thanks for your PR ❤️ Sorry for being a PITA, but could you describe the PR using the template, for bookkeeping purpose? I know it's just a typo fix, but future users might not have the patience to check changes, and would therefore benefit from a short description 😉 Furthermore, could you be so kind to sign-off your commit?

Will follow the template next time as well the signoff commit messages. Didn't know. I'll take it for granted! Someone could apply it to it's next PR.

yzhao244 and others added 5 commits July 18, 2024 15:26
@yzhao244 @zolero
Signed-off-by: Yuri Zhao <yu.zhao5@huawei.com>
58eed74 
fix task run hyperlinks and add allowing another workflow description

Signed-off-by: Yuri Zhao <yu.zhao5@huawei.com>
Signed-off-by: Joost van Berkel <joost@the.haus>
@yzhao244 @zolero
missing dsl reference
0c900ca 
Signed-off-by: Yuri Zhao <yu.zhao5@huawei.com>
Signed-off-by: Joost van Berkel <joost@the.haus>
@matthias-pichler @zolero
feat: add titles to tasks
fe6808c 
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Joost van Berkel <joost@the.haus>
@zolero
Fixed typo RunWokflow
c1d420b 
Signed-off-by: Joost van Berkel <joost@the.haus>
@cdavernas
Merge branch 'main' into main
02aff91
cdavernas
cdavernas approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers ❤️

@ricardozanini
Copy link
Member

ricardozanini commented Jul 31, 2024

@zolero can you please rebase it?

@ricardozanini
Copy link
Member

ricardozanini commented Jul 31, 2024

Nevermind, I did it already.

@ricardozanini ricardozanini merged commit e9700ae into serverlessworkflow:main Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@cdavernas cdavernas cdavernas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zolero @cdavernas @ricardozanini @yzhao244 @matthias-pichler

Comments