Added a new until property to any event consumption strategies#997
Merged
cdavernas merged 4 commits intoserverlessworkflow:mainfrom Jan 10, 2025
Merged
Conversation
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
Member
Author
|
@matthias-pichler Any suggestion on how to achieve the following in a brief, concise fashion?
|
matthias-pichler
suggested changes
Sep 5, 2024
Collaborator
Hmm we could do it with until:
oneOf:
- type: string
- allOf:
- $ref: #/$defs/eventConsumptionStrategy
- type: object
properties:
until: false |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
ricardozanini
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please specify parts of this PR update:
Discussion or Issue link:
Closes #992
What this PR does:
Added a new
untilproperty toanyevent consumption strategiesAdditional information:
We need to find a smart way to forbid an
untilevent consumption strategy to itself define theuntilproperty.