-
Notifications
You must be signed in to change notification settings - Fork 12
docs: Adds a docusaurus documentation page for relic. #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 84.20% 84.20%
=======================================
Files 83 83
Lines 2716 2716
Branches 1480 1480
=======================================
Hits 2287 2287
Misses 429 429 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nielsenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like a oddly high line count for an empty docs site 😄
|
The build failure is simply the dependency check that has spotted a newer version of a dependency that cannot be used with relic, given its current pubspec.yaml. This will prevent others from upgrading said dependency ( #127 fixes that. |
|
I agree that this is a crazy high line count. The package-lock.json is 17k lines... 🙃 |
f12f067 to
b861db5
Compare
b861db5 to
5486a60
Compare
|
@SandPod @nielsenko Where can I find url to relic documentation? I would love to contribute but Im not able to find it anywhere |
|
OK I found it here https://github.com/serverpod/relic/tree/main/doc/site/docs But maybe its a good idea to split is the same way as it is in Serverpod case? There is Serverpod and Serverpod Docs so Dart code dont mix with JavaScript docusaurus and you can keep 100% Dart in Relic Repo. I think that in the long term it will bring more benefits than mixing it all together |
|
@Tananga, The main benefit of having this in a shared repo is to ensure that new features are documented directly in the PR. Since this is a smaller project, we don't need to split these in separate repos. You can also access the Relic documentation here: https://docs.dartrelic.dev Although the documentation is still empty, we will add a link to this in the Readme. |
Description
Adds a docusaurus documentation page and ci for automatic deployments and runs.
Not really sure why the ci fails when varifying build as this does not touch any other changes than the docs and workflows. But this PR can wait for #127
After this is deployed the temporary link to the documentation will be generated that needs to be updated in the configuration.
Related Issues
Related to: #39