Skip to content

fix: remove debug print messages for failed client calls #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hampuslavin merged 2 commits into from
Jan 14, 2025
Merged

fix: remove debug print messages for failed client calls #3117

hampuslavin merged 2 commits into from
Jan 14, 2025

Conversation

@hampuslavin
Copy link
Contributor

@hampuslavin hampuslavin commented Jan 13, 2025 •
edited
Loading

Description

Pre-launch Checklist

  • I read the Contribute page and followed the process outlined there for submitting PRs.
  • This update contains only one single feature or bug fix and nothing else. (If you are submitting multiple fixes, please make multiple PRs.)
  • I read and followed the Dart Style Guide and formatted the code with dart format.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///), and made sure that the documentation follows the same style as other Serverpod documentation. I checked spelling and grammar.
  • I added new tests to check the change I am making.
  • All existing and new tests are passing.
  • Any breaking changes are documented below.

@hampuslavin hampuslavin requested a review from SandPod January 13, 2025 15:37
SandPod
SandPod reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to clean this up, single question!

SandPod
SandPod approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

@hampuslavin hampuslavin merged commit e1fae90 into serverpod:main Jan 14, 2025
67 checks passed
@hampuslavin hampuslavin deleted the hl_1557_remove_debug_print_in_client branch January 14, 2025 06:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SandPod SandPod SandPod approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prints from serverpod_client.

2 participants

@hampuslavin @SandPod