Fix the GitHub CI build#390
Conversation
This fixes an issue with missing repository keys.
mrobinson
force-pushed
the
fix-ci-kernel-repo
branch
4 times, most recently
from
640e811 to
66c473f
Compare
This also removes the installation of the pre-packaged GStreamer build in exchange for the one from upstream Ubuntu.
mrobinson
force-pushed
the
fix-ci-kernel-repo
branch
from
66c473f to
e90e788
Compare
mrobinson
changed the title
apt-add-repository
mrobinson
force-pushed
the
fix-ci-kernel-repo
branch
3 times, most recently
from
bdcbd77 to
c875892
Compare
This gets things compiling on modern systems and makes sure that the dependencies are compatible with one another.
mrobinson
force-pushed
the
fix-ci-kernel-repo
branch
from
c875892 to
d3a231c
Compare
|
Okay. After a lot of wrestling with cargo and GitHub runners, I think this PR is ready to be merged. It gets the CI working again. |
mrobinson
force-pushed
the
fix-ci-kernel-repo
branch
from
d3a231c to
ec4d1e5
Compare
| run: cargo build | ||
| - name: Examples | ||
| run: | | ||
| ls examples/*.rs | xargs -I{} basename {} .rs | grep -v params_connect | RUST_BACKTRACE=1 GST_DEBUG=3 xargs -I{} cargo ex {} --all-features |
There was a problem hiding this comment.
Why aren't we running the examples anymore?
There was a problem hiding this comment.
feel free to r=me to fix the immediate problem though
There was a problem hiding this comment.
At least for me, one of these examples did not finish executing on my local machine. Perhaps I didn't wait long enough for that to happen though. I'll play around a bit locally.
There was a problem hiding this comment.
It seems this works on CI while running the examples, so I have removed that commit.
mrobinson
force-pushed
the
fix-ci-kernel-repo
branch
from
ec4d1e5 to
e9b29e7
Compare
|
@bors-servo r=Manishearth |
|
📌 Commit e9b29e7 has been approved by |
|
Thanks for the review! |
|
☀️ Test successful - checks-github, status-appveyor |
3 participants
This PR fixes various issues that were preventing the CI from successfully running.