Added Support for External Latin1 Strings#481
Merged
sagudev merged 4 commits intoservo:mainfrom Aug 14, 2024
Merged
Conversation
redfire75369
force-pushed
the
string/external-latin1
branch
2 times, most recently
from
e0e716f to
6dc8084
Compare
Member
|
This will need a rebase and an increment mozjs-sys version (and probably companion PR in servo, but I can take care of it if you want after #474 is in servo). |
redfire75369
force-pushed
the
string/external-latin1
branch
6 times, most recently
from
d77f852 to
5e933bb
Compare
Member
|
I will check this in the upcoming week, but it would be nice to also have tests for both ExternalStrings. |
redfire75369
force-pushed
the
string/external-latin1
branch
from
3928d23 to
7066c12
Compare
Contributor
Author
|
Added Some Tests based on the External String code in spiderfire in ion/string/mod.rs and ion/src/utils.rs. |
Member
|
Needs rebase. |
Signed-off-by: Redfire <redfire75369@hotmail.com>
Added 80 Column Limit to .clang-format Signed-off-by: Redfire <redfire75369@hotmail.com>
Fixed Some Compiler Warnings Signed-off-by: Redfire <redfire75369@hotmail.com>
Signed-off-by: Redfire <redfire75369@hotmail.com>
redfire75369
force-pushed
the
string/external-latin1
branch
from
7066c12 to
e9aef54
Compare
sagudev
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added support for external latin1 strings, added in bug 1576076. I've also updated the
.clang-formatbased on bug 1851529, and reformatted the C++ files accordingly.Requires #474