Merged
Conversation
3a539ba to
ca6d709
Compare
Member
|
About symbol visibility you should read servo/servo#32769 (comment), so I think you only need to do something like: system_headers += [
'hilog/log.h',
]also this is something that is not really servo specific, so you should try to upstream it. |
Member
Author
Thanks! That looks exactly like what I want.
That is my plan. But I want to get it working with servo first, and then tackle rebasing to latest upstream (and hope upstream is interested). |
ca6d709 to
72ee408
Compare
Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
72ee408 to
820da15
Compare
Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
35c2586 to
f170b1c
Compare
Member
|
All PRs that change mozjs-sys/mozjs or other cpp code need to bump mozjs-sys version. |
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
f51178f to
5ebf888
Compare
3 tasks
sagudev
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to android, stderr output is generally not visible on OpenHarmony devices. Error messages should instead be logged via the
hiloglogging service.During normal operations, we can also do a workaround where we redirect stderr to hilog via a dedicated logging thread.
However, for fatal errors such as failed assertions, which lead to the whole process dying, this solution is not sufficient, since the process might die before the logging thread has a chance to print the error message it received on
stderr.