Fix mmap for JIT code on HarmonyOS NEXT Beta 2#491
Merged
sagudev merged 5 commits intoservo:mainfrom Aug 6, 2024
Merged
Conversation
jschwe
force-pushed
the
jschwender/harmonyos_mmap
branch
from
e019bd7 to
769b3c9
Compare
Taym95
reviewed
Aug 5, 2024
mozjs-sys/etc/patches/0034-build__Add_compile_definition_for_ohos.patch
Outdated
Show resolved
Hide resolved
Taym95
reviewed
Aug 5, 2024
mozjs-sys/etc/patches/0034-build__Add_compile_definition_for_ohos.patch
Outdated
Show resolved
Hide resolved
jschwe
force-pushed
the
jschwender/harmonyos_mmap
branch
2 times, most recently
from
ba442a9 to
e198e7b
Compare
sagudev
requested changes
Aug 5, 2024
Member
sagudev
left a comment
sagudev
left a comment
There was a problem hiding this comment.
I think we need to bump mozjs-sys version for this and it would be nice to add ohos in CI (like it is in servo), so we can land with more confidence that it compiles (ideally in separate PR).
Member
Author
Sure, I'll open a separate PR for that as suggested. |
Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
The Security policy for JIT code is tightening and as a first step, we need to pass `MAP_EXECUTABLE` (internally same as `MAP_JIT`) to the committing mmap, otherwise it will fail. Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
jschwe
force-pushed
the
jschwender/harmonyos_mmap
branch
from
f2ba7a7 to
588ff20
Compare
3 tasks
sagudev
approved these changes
Aug 6, 2024
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Security policy for JIT code is tightening on HarmonyOS . Beta 2 and newer require us to pass
MAP_EXECUTABLE(internally same asMAP_JIT) to the committing mmap, otherwise it will fail.