Open
Conversation
This adds a simple script to create patches for etc/patches based on an existing commit. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a simple script to create patches for etc/patches based on an existing commit.
I previously always forgot the commands to create a patch and used to hand-edit patches so that they apply to the correct subdirectory. That's obviously a waste of time, hence here a small script which creates a patch file from an existing commit, and verifies that the patch applies.
It supports optionally printing the patch to stdout (so you can pipe it into other tools if necessary), writing to a specific file (so you can overwrite a previous patch, e.g. if you edited your local commit) and by default creates a new patch file with the correct number (until we hit 9999 patches, then a script update will be necessary).
Testing: Basic manual testing by running the script locally.
Servo PR: Not required, mozjs internal change.