Skip to content

layout: Add support for -webkit-text-security#42181

Merged
mrobinson merged 1 commit intoservo:mainfrom
mrobinson:webkit-text-security
Jan 31, 2026
Merged

layout: Add support for -webkit-text-security#42181
mrobinson merged 1 commit intoservo:mainfrom
mrobinson:webkit-text-security

Conversation

@mrobinson
Copy link
Copy Markdown
Member

@mrobinson mrobinson commented Jan 27, 2026

This change adds support for the unspecified -webkit-text-security
property. All major browsers support this property. The benefit of
adding this property is that the first addition of a prefixed CSS
property will allow us to start running MotionMark.

This depends on servo/stylo#295.

Testing: Three new Servo-specific tests are added for this change. There
are a few -webkit-text-security tests in WPT, but they do not seem
to test basic functionality.

@mrobinson mrobinson requested a review from Loirooriol as a code owner January 27, 2026 10:30
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 27, 2026
fn next(&mut self) -> Option<Self::Item> {
// The behavior of `-webkit-text-security` isn't specified, so we have some
// flexibility in the implementation. We just need to maintain a rough
// compatability with other browsers.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// compatability with other browsers.
// compatibility with other browsers.

@servo-highfive servo-highfive added S-needs-rebase There are merge conflict errors. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jan 31, 2026
github-merge-queue Bot pushed a commit to servo/stylo that referenced this pull request Jan 31, 2026
This change adds support for the unspecified `-webkit-text-security`
property. All major browsers support this property. The benefit of
adding this property is that the first addition of a prefixed CSS
property will allow us to start running MotionMark.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
@mrobinson mrobinson force-pushed the webkit-text-security branch from 663df33 to b6d0f55 Compare January 31, 2026 19:06
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-rebase There are merge conflict errors. labels Jan 31, 2026
@mrobinson mrobinson enabled auto-merge January 31, 2026 19:06
@mrobinson mrobinson added this pull request to the merge queue Jan 31, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 31, 2026
Merged via the queue into servo:main with commit db2a7cb Jan 31, 2026
32 checks passed
@mrobinson mrobinson deleted the webkit-text-security branch January 31, 2026 20:04
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 31, 2026
Loirooriol pushed a commit to servo/stylo that referenced this pull request Feb 5, 2026
Loirooriol pushed a commit to servo/stylo that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants