Skip to content

Remove parse condition step_position_jump_enabled#323

Merged
Loirooriol merged 2 commits intoservo:mainfrom
yezhizhen:this-should-work
Mar 9, 2026
Merged

Remove parse condition step_position_jump_enabled#323
Loirooriol merged 2 commits intoservo:mainfrom
yezhizhen:this-should-work

Conversation

@yezhizhen
Copy link
Copy Markdown
Member

@yezhizhen yezhizhen commented Mar 6, 2026

This enables jump-start, jump-end, jump-none, jump-both.

The feature is left here 7 years ago. As tested with examples, all step-easing-functions work as expected.

Servo PR: servo/servo#43061

@yezhizhen
Copy link
Copy Markdown
Member Author

Pls don't merge yet to not block others. I have questions that may need further change to Servo PR: servo/servo#43061 (comment)

@yezhizhen
Copy link
Copy Markdown
Member Author

yezhizhen commented Mar 8, 2026

@Loirooriol If the tests added look ok, can you merge this? All other browsers pass them too.

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>>
@yezhizhen yezhizhen requested a review from Loirooriol March 9, 2026 09:45
@Loirooriol Loirooriol added this pull request to the merge queue Mar 9, 2026
Merged via the queue into servo:main with commit 51593b0 Mar 9, 2026
5 checks passed
@yezhizhen yezhizhen deleted the this-should-work branch March 9, 2026 10:00
@yezhizhen
Copy link
Copy Markdown
Member Author

I don't know how to export this to upstream btw..

github-merge-queue Bot pushed a commit to servo/servo that referenced this pull request Mar 9, 2026
…osition (#43061)

Bumps stylo to servo/stylo#323
As tested with examples, all step-position keywords now work:
https://drafts.csswg.org/css-easing-2/#typedef-step-position

Testing: New passing WPT. Several in `moveBefore` goes from TIMEOUT to
`FAIL`, as the API is not enabled in Servo. Added 4 new tests to test
the proper rendering.
Fixes: #43060

---------

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
github-merge-queue Bot pushed a commit to servo/servo that referenced this pull request Mar 9, 2026
…osition (#43061)

Bumps stylo to servo/stylo#323
As tested with examples, all step-position keywords now work:
https://drafts.csswg.org/css-easing-2/#typedef-step-position

Testing: New passing WPT. Several in `moveBefore` goes from TIMEOUT to
`FAIL`, as the API is not enabled in Servo. Added 4 new tests to test
the proper rendering.
Fixes: #43060

---------

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
@Loirooriol
Copy link
Copy Markdown
Collaborator

I don't know how to export this to upstream btw..

See https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#firefox-contributors-quick-reference

Otherwise I will do a batch export it next month.

lando-worker Bot pushed a commit to mozilla-firefox/firefox that referenced this pull request Apr 3, 2026
github-actions Bot pushed a commit to longvatrong111/stylo that referenced this pull request Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants