Restore Servo's original form control theme colors#327
Merged
Conversation
Collaborator
No? <!DOCTYPE html>
<button style="color-scheme: light">button</button>
<button style="color-scheme: dark">button</button>Firefox: Chrome: WebKit: |
Member
Author
That is when the 
Also, note that this was calling pub(crate) fn is_dark_color_scheme(&self, _: ColorSchemeFlags) -> bool {
false
} |
Member
Author
|
It's quite possible you are correct about the EDIT: I've updated the PR description to reflect this. |
mrobinson
force-pushed
the
restore-servo-original-form-theme-colors
branch
from
258fde4 to
dbf89be
Compare
Restores Servo's original theme colors from before support for system color was added. Also, note that the dark theme code path is dead in a comment. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson
force-pushed
the
restore-servo-original-form-theme-colors
branch
from
dbf89be to
330f77e
Compare
Loirooriol
approved these changes
Mar 9, 2026
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 10, 2026
…theme colors" (#43107) This change just updates the version of Stylo to a version which restores the original Servo theme colors. Stylo PR: servo/stylo#327 Testing: This just restore the original form control theme colors, so should not change test results. Manual testing was performed with the `form-controls-visual.html` test. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 10, 2026
…theme colors" (#43107) This change just updates the version of Stylo to a version which restores the original Servo theme colors. Stylo PR: servo/stylo#327 Testing: This just restore the original form control theme colors, so should not change test results. Manual testing was performed with the `form-controls-visual.html` test. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 10, 2026
…theme colors" (#43107) This change just updates the version of Stylo to a version which restores the original Servo theme colors. Stylo PR: servo/stylo#327 Testing: This just restore the original form control theme colors, so should not change test results. Manual testing was performed with the `form-controls-visual.html` test. One form tests starts to fail due to subpixel differences. This test was failing originally (before form control style was inadvertently changed). This likely happens due to the rounded grey borders of buttons. This PR changes them back to gray from black. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Apr 3, 2026
…irefox-style-system-reviewers,dshin Imports servo/stylo#327 Differential Revision: https://phabricator.services.mozilla.com/D291907
github-actions Bot
pushed a commit
to longvatrong111/stylo
that referenced
this pull request
Apr 4, 2026
…irefox-style-system-reviewers,dshin Imports servo#327 Differential Revision: https://phabricator.services.mozilla.com/D291907
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change does two things:
is_dark_color_schemealways returnsfalse.Servo PR: servo/servo#43107