Unify ListStyleType among Gecko and Servo#329
Merged
Loirooriol merged 1 commit intoservo:mainfrom Mar 11, 2026
Merged
Conversation
This makes Servo use the same as Gecko. In particular: - `counter()` and `counters()` will no longer accept a `none` style. - `list-style-type` will now accept a string. - Both `list-style-type` and counters will now accept arbitrary keywords. However, Servo's flavor of Stylo will still reject `@counter-style` rules. So non-predefined keywords will just default to `decimal`. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Loirooriol
changed the title
ListStyleType with among Gecko and ServoListStyleType among Gecko and Servo
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 11, 2026
Bumps Stylo to servo/stylo#329, and modifies the code accordingly: - Implements basic `counter()` and `counters()`, instead of treating them as empty string. - For `list-style-type`, uses normal space instead of non-breaking space in the suffix, since `::marker` has `white-space: pre` anyways. `counter()` and `counters()` don't get a suffix. - Changes `disclosure-closed` to use ▸ (U+25B8 Black Right-Pointing Small Triangle) instead of ‣ (U+2023 Triangular Bullet). - Implements `list-style-type: <string>`. - Implements basic `<counter-style-name> | <symbols()>` for both counters and `list-style-type`. However, since `@counter-style` and `counter-*` properties are still unsupported, non-predefined keywords just default to decimal, and counters are assumed to have a value of 0. The UA stylesheet is tweaked to avoid a problem when `list-style-type` is set to a string with multiple lines. Testing: 63 tests improve, 17 tests worsen (they were falsely passing beforehand) - #43117 - `tests/wpt/tests/css/css-lists/content-property/marker-text-matches-circle.html` - `tests/wpt/tests/css/css-lists/content-property/marker-text-matches-disc.html` - `tests/wpt/tests/css/css-lists/content-property/marker-text-matches-square.html` - #43118 - `tests/wpt/tests/css/css-lists/nested-marker-dynamic.html` - `tests/wpt/tests/css/css-lists/nested-marker.html` - #43036 - `tests/wpt/tests/css/css-lists/list-style-type-decimal-line-height.html` - `tests/wpt/tests/css/css-pseudo/marker-content-002.html` - `tests/wpt/tests/css/css-pseudo/marker-content-003.html` - `tests/wpt/tests/css/css-pseudo/marker-content-003b.html` - `tests/wpt/tests/css/css-pseudo/marker-content-004.html` - `tests/wpt/tests/css/css-pseudo/marker-content-005.html` - `tests/wpt/tests/css/css-pseudo/marker-content-015.html` - `tests/wpt/tests/css/css-pseudo/marker-content-016.html` - `tests/wpt/tests/css/css-pseudo/marker-content-018.html` - #30365 - `tests/wpt/tests/css/css-pseudo/marker-font-variant-numeric-default.html` - `tests/wpt/tests/css/css-pseudo/marker-line-height.html` - #43119 - `tests/wpt/tests/css/css-pseudo/marker-tab-size.html` Fixes: #43037 Signed-off-by: Oriol Brufau <obrufau@igalia.com>
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Apr 3, 2026
…style-system-reviewers,dshin Imports servo/stylo#329 Differential Revision: https://phabricator.services.mozilla.com/D291908
github-actions Bot
pushed a commit
to longvatrong111/stylo
that referenced
this pull request
Apr 4, 2026
…style-system-reviewers,dshin Imports servo#329 Differential Revision: https://phabricator.services.mozilla.com/D291908
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes Servo use the same
ListStyleTypeas Gecko. In particular:counter()andcounters()will no longer accept anonestyle.list-style-typewill now accept a string.list-style-typeand counters will now accept arbitrary keywords. However, Servo's flavor of Stylo will still reject@counter-stylerules. So non-predefined keywords will just default todecimal.list-style-typeand counters will now acceptsymbols().