Don't skip animations without keyframes#336
Merged
nicoburns merged 1 commit intoservo:mainfrom Mar 20, 2026
Merged
Conversation
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Loirooriol
approved these changes
Mar 20, 2026
Member
Author
|
Can someone merge this? |
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 20, 2026
Companion PR for servo/stylo#336 Testing: This fixes a bunch of timeouts --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 20, 2026
Companion PR for servo/stylo#336 Testing: This fixes a bunch of timeouts --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
niyabits
pushed a commit
to niyabits/servo
that referenced
this pull request
Mar 21, 2026
Companion PR for servo/stylo#336 Testing: This fixes a bunch of timeouts --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> Signed-off-by: Niya Gupta <niyabits@gmail.com>
Gae24
pushed a commit
to Gae24/servo
that referenced
this pull request
Mar 26, 2026
Companion PR for servo/stylo#336 Testing: This fixes a bunch of timeouts --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Apr 3, 2026
…efox-style-system-reviewers,emilio Imports servo/stylo#336 Differential Revision: https://phabricator.services.mozilla.com/D291912
github-actions Bot
pushed a commit
to longvatrong111/stylo
that referenced
this pull request
Apr 4, 2026
…efox-style-system-reviewers,emilio Imports servo#336 Differential Revision: https://phabricator.services.mozilla.com/D291912
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently never start animations that have no keyframes.
That is not correct. While such an animation will never change any styles, it should still fire
animationstartandanimationendevents at the correct time, and that requires the animation to start first.Servo companion PR: servo/servo#43454