Refactor how we initiate polling#1882
Merged
SessionHero01 merged 6 commits intorelease/1.31.0from Feb 3, 2026
Merged
Conversation
app/src/main/java/org/session/libsession/messaging/sending_receiving/pollers/BasePoller.kt
Outdated
Show resolved
Hide resolved
| ): Int { | ||
| return successfulPollIntervalSeconds + | ||
| ((numConsecutiveFailures - 1).coerceAtLeast(0) * successfulPollIntervalSeconds) | ||
| .coerceAtMost(maxRetryIntervalSeconds) |
Collaborator
There was a problem hiding this comment.
Shouldn't we coerce the overall value?
val delay = successfulPollIntervalSeconds * (numConsecutiveFailures + 1)
return delay.coerceAtMost(maxRetryIntervalSeconds)
```
ThomasSession
approved these changes
Feb 3, 2026
SessionHero01
added a commit
that referenced
this pull request
Feb 3, 2026
* Bump version number * Fix snode pool retrieve failure (#1875) * Update seed snode download mechanism (#1879) * Fix : Manage members QA pt.4 (#1881) * Send control message before exception * Add sorting by accountId when showing new dialogs * cleanup * cleanup for readability * Cleanups * Refactor how we initiate polling (#1882) --------- Co-authored-by: ThomasSession <thomas.r@getsession.org> Co-authored-by: jbsession <jb@getsession.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to simplify and unify how we control our pollers.
Previously we have three similar but different ways of controlling
Poller,GroupPollerandOpenGroupPoller, each of them also has similar but different way to run periodically.In this change, we'll have
BasePollerwhere the periodic polling, manual polling is all handled and the subclasses just need to provide the implementation ofdoPollOnce.