Test on Windows and macOS #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, cffi needs to be installed from Github source for Python 3.13 until their next release, like in this PR: pypa/pip#12620 |
Owner
Author
|
@notatallshaw Thanks for the link, I'll give that a try :) |
sethmlarson
force-pushed
the
test-other-oses
branch
from
59b5927 to
a2746bf
Compare
sethmlarson
force-pushed
the
test-other-oses
branch
from
a2746bf to
4e7819d
Compare
Owner
Author
|
@davisagli I believe what's happening is that we're seeing one type ( |
davisagli
approved these changes
May 6, 2024
Collaborator
davisagli
left a comment
davisagli
left a comment
There was a problem hiding this comment.
@sethmlarson LGTM, but I wonder if that inconsistency should be reported upstream
Owner
Author
|
@davisagli Definitely, here's the upstream issue: python/cpython#118658 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.