chore: fix CI failures: missing TypeScript types and Svelte HTML warnings #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g Svelte HTML warnings - Add @typescript-eslint/types as dev dependency to fix esrap import error - Close <p> tags properly before <blockquote> and <ul> in About.svelte - Fix self-closing HTML tags in App.svelte and Calibrate.svelte Co-authored-by: sethrylan <1923436+sethrylan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing CI and test failures
Fix CI failures: missing TypeScript types and Svelte HTML warnings
Jan 24, 2026
sethrylan
changed the base branch from
main
to
dependabot/npm_and_yarn/npm-development-254d415edd
sethrylan
changed the title
…o copilot/fix-ci-and-test-failures
sethrylan
merged commit d343d9f
into
dependabot/npm_and_yarn/npm-development-254d415edd
2 checks passed
sethrylan
added a commit
that referenced
this pull request
Jan 24, 2026
… updates (#122) * chore(deps): bump the npm-development group across 1 directory with 4 updates Bumps the npm-development group with 4 updates in the / directory: [highcharts](https://github.com/highcharts/highcharts-dist), [rollup](https://github.com/rollup/rollup), [svelte](https://github.com/sveltejs/svelte/tree/HEAD/packages/svelte) and [svelte-check](https://github.com/sveltejs/language-tools). Updates `highcharts` from 12.4.0 to 12.5.0 - [Commits](highcharts/highcharts-dist@v12.4.0...v12.5.0) Updates `rollup` from 4.53.3 to 4.55.1 - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.53.3...v4.55.1) Updates `svelte` from 5.43.14 to 5.46.3 - [Release notes](https://github.com/sveltejs/svelte/releases) - [Changelog](https://github.com/sveltejs/svelte/blob/main/packages/svelte/CHANGELOG.md) - [Commits](https://github.com/sveltejs/svelte/commits/svelte@5.46.3/packages/svelte) Updates `svelte-check` from 4.3.4 to 4.3.5 - [Release notes](https://github.com/sveltejs/language-tools/releases) - [Commits](https://github.com/sveltejs/language-tools/compare/svelte-check@4.3.4...svelte-check@4.3.5) --- updated-dependencies: - dependency-name: highcharts dependency-version: 12.5.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-development - dependency-name: rollup dependency-version: 4.55.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-development - dependency-name: svelte dependency-version: 5.46.3 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-development - dependency-name: svelte-check dependency-version: 4.3.5 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-development ... Signed-off-by: dependabot[bot] <support@github.com> * chore: fix CI failures: missing TypeScript types and Svelte HTML warnings (#123) * Initial plan * fix: resolve CI failures by adding missing TypeScript types and fixing Svelte HTML warnings - Add @typescript-eslint/types as dev dependency to fix esrap import error - Close <p> tags properly before <blockquote> and <ul> in About.svelte - Fix self-closing HTML tags in App.svelte and Calibrate.svelte Co-authored-by: sethrylan <1923436+sethrylan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sethrylan <1923436+sethrylan@users.noreply.github.com> Co-authored-by: Seth Rylan Gainey <seth.rylan@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: sethrylan <1923436+sethrylan@users.noreply.github.com> Co-authored-by: Seth Rylan Gainey <seth.rylan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI failing due to
esrap(Svelte transitive dep) importing@typescript-eslint/typeswithout declaring it as a dependency, plussvelte-checktreating HTML structure warnings as errors.Changes
Missing dependency
@typescript-eslint/typesas dev dependency to satisfyesrap's type declarationsSvelte HTML fixes
About.svelte: Close<p>tags before<blockquote>and<ul>to prevent implicit closingApp.svelte:<html lang="en" />→<html lang="en"></html>Calibrate.svelte:<div ... />→<div ...></div>Self-closing syntax on non-void elements is ambiguous per Svelte 5's stricter checking.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.