Remove std::experimental::dynarray from array passing example#74
Closed
GabrielDougherty wants to merge 1 commit intosftrabbit:masterfrom
Closed
Remove std::experimental::dynarray from array passing example#74GabrielDougherty wants to merge 1 commit intosftrabbit:masterfrom
GabrielDougherty wants to merge 1 commit intosftrabbit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #73 where the inclusion of the no longer supported std::experimental::dynarray prevents compilation. I opted to just remove the dynarray code and supporting part of the article, but I understand that there's no longer any example that provides a fixed-size array which has a size defined at runtime. So, I am interested if you have any example you would prefer instead.
I tried to maintain the spirit of your original article, but I would appreciate a review of the language, and please let me know if you would like anything added. Thanks!