Update man pages for chage, shadow, passwd #1243
Conversation
|
I have applied your first two patches into my PR. I've signed them on your behalf (with some minor tweaks too). Thanks! The rest still need some review. |
ikerexxe
left a comment
ikerexxe
left a comment
There was a problem hiding this comment.
Some minor comments inline
|
Hi! Sorry for the pause. There were some high priority items I had to address. |
domiborges
changed the title
|
@ikerexxe are you going to fix the git history? |
|
I would like to review myself too. Please don't merge for now. |
| <command>passwd</command> will reject any password which is not | ||
| suitably complex. Care must be taken not to include the system | ||
| default erase or kill characters. | ||
| <command>passwd</command> rejects passwords that do not meet | ||
| the complexity requirements. | ||
| Do not include the system default erase or kill characters. |
There was a problem hiding this comment.
[Not a question about the documentation change, but about the old text (and the program behavior)].
@ikerexxe , @hallyn is this a warning to not introduce bad characters in passwords? Should we add checks like we have for the user name? Care must be taken sounds like it will break something in /etc/passwd, which sounds like we should check.
| The minimum password age is the number of days the user will | ||
| have to wait before she will be allowed to change her password | ||
| again. | ||
| The minimum password age is the number of days the user must wait | ||
| before they can change their password again. |
| The maximum password age is the number of days after which the | ||
| user will have to change her password. | ||
| user must change their password. | ||
| </para> | ||
| <para> | ||
| After this number of days is elapsed, the password may still | ||
| be valid. The user should be asked to change her password the | ||
| next time she will log in. | ||
| After this number of days has elapsed, the password may still be valid. | ||
| The user is prompted to change their password at the next login. |
alejandro-colomar
left a comment
alejandro-colomar
left a comment
There was a problem hiding this comment.
Thanks a lot!
Reviewed-by: Alejandro Colomar <alx@kernel.org>
|
I'm ok with the documentation but I think we need to fix the git history a bit before merging. Let's see if I can meet Dominika next week and fix that. In any case, this shouldn't block any release. |
Yeah, we can merge this after the RC; it's just docs. |
ikerexxe
left a comment
ikerexxe
left a comment
There was a problem hiding this comment.
I misunderstood some of the changes and I thought we needed to rewrite a little bit the git history before merging, but this is good as it is. Thank you for the patches! Merging them now.
4 participants
Hi! @ikerexxe suggested I could use the opportunity of #1238 to review and update these man pages. I did an initial review so we can start a discussion.
I'm marking the PR as a draft as it depends on #1238