Quick fix: define E_PAM_ERR in lib/pam_pass.c #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exit code situation is a hot mess. Do a git grep "define.*E_SUCCESS" Each src/*.c is defining its own set of error codes, and they are frequently conflicting, e.g. more than one use 10. We should probably have a common set defined in lib/exitcodes.h. I'm thinking for a first cut, we just move all the definitions from src/*.c to lib/exitcodes.h, and let the conflicts stand. If we later want to change some defines to make them unambiguous across the project, we can do that separately. Signed-off-by: Serge Hallyn <serge@hallyn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exit code situation is a hot mess. Do a
git grep "define.E_SUCCESS"
Each src/.c is defining its own set of error codes, and they are frequently conflicting, e.g. more than one use 10.
We should probably have a common set defined in lib/exitcodes.h. I'm thinking for a first cut, we just move all the definitions from src/*.c to lib/exitcodes.h, and let the conflicts stand. If we later want to change some defines to make them unambiguous across the project, we can do that separately.