Expand system test framework #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikerexxe
force-pushed
the
test-newusers
branch
from
01395aa to
1dee03d
Compare
Collaborator
Author
|
@danlavu can you review this PR? |
|
Ack, will do it today. |
danlavu
reviewed
Aug 27, 2025
danlavu
left a comment
danlavu
left a comment
There was a problem hiding this comment.
A lot of suggestions and preferences. Other than that, it looks good.
ikerexxe
force-pushed
the
test-newusers
branch
from
1dee03d to
39db594
Compare
|
I do not have permissions to approve. The PR looks good. |
Collaborator
Author
Thank you for the review! |
ikerexxe
force-pushed
the
test-newusers
branch
from
39db594 to
e725b96
Compare
Temporary workaround to create the newusers PAM service file. Fedora will soon provide this service file and we'll be able to remove the workaround. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
This is the transformation to Python of the test located in `tests/newusers/35_read_from_stdin/newusers.test`, which checks that `newusers` is able to create new users from stdin. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
… input This is the transformation to Python of the test located in `tests/newusers/20_multiple_users/newusers.test`, which checks that `newusers` is able to create new users from file. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Temporary workaround to create the groupmems PAM service file. Fedora will soon provide this service file and we'll be able to remove the workaround. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
…ems` Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
This is the transformation to Python of the test located in `tests/grouptools/groupmems/01_groupmems_root_add_user/groupmems.test`, which checks that `groupmems` is able to add a user to a group running as the root user. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Change to a new group using `newgrp`. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
ikerexxe
force-pushed
the
test-newusers
branch
from
e725b96 to
390aa4a
Compare
Collaborator
Author
|
@alejandro-colomar this one is also ready for merging |
hallyn
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the system test framework to provide python bindings for
newusers,groupmemsandnewgrpbinaries. Also include at least one test case example for each of them. Additional changes has been made to the way we generate the test environment (a.k.a. containers) so that it contains everything needed to run these tests.