Skip to content

CI: add Python linter #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ikerexxe merged 4 commits into from
Sep 10, 2025
Merged

CI: add Python linter #1349

ikerexxe merged 4 commits into from
Sep 10, 2025

Conversation

@ikerexxe
Copy link
Collaborator

@ikerexxe ikerexxe commented Sep 2, 2025

  • Add rules for linters
  • Fix existing Python linter issues
  • Add Python linters to CI

@ikerexxe
tests/system/pyproject.toml: add mypy rules
428f396 
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
@ikerexxe
tests/system/framework/: fix Python linter issues
b05a9bf 
Fix issues reported by flake8, pycodestyle, isort, black and mypy.

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
@ikerexxe
tests/system/tests/: fix Python linter issues
daed1d8 
Fix issues reported by flake8, pycodestyle, isort, black and mypy.

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
@ikerexxe
.github/workflows/static-code-analysis.yml: add Python linters
4a902a1 
Add flake8, pycodestyle, isort, black and mypy in CI for Python linting.

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
@ikerexxe ikerexxe marked this pull request as ready for review September 2, 2025 07:32
lslebodn
lslebodn approved these changes Sep 3, 2025
View reviewed changes
Copy link

@lslebodn lslebodn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

+1

@ikerexxe
Copy link
Collaborator Author

ikerexxe commented Sep 10, 2025

@alejandro-colomar do you mind taking a look? I'm fine with both a full review or just an approval so that I can merge this work.

@alejandro-colomar
Copy link
Collaborator

alejandro-colomar commented Sep 10, 2025 •
edited
Loading

@alejandro-colomar do you mind taking a look? I'm fine with both a full review or just an approval so that I can merge this work.

I had a look at it some days ago. I love the idea of the PR. But I have no clue of the changes (again, the problem is Python). I was hoping that @hallyn would have a look at it. I can approve it, though; I don't mind.

alejandro-colomar
alejandro-colomar approved these changes Sep 10, 2025
View reviewed changes
Copy link
Collaborator

@alejandro-colomar alejandro-colomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll approve. Feel free to merge or wait for @hallyn to comment, as you prefer. Anyway, we're always in time to revert something if we later don't like it.

@ikerexxe
Copy link
Collaborator Author

ikerexxe commented Sep 10, 2025

Thank you! In this case, we are enforcing a stricter use of Python than usual for shadow. If anyone wishes to change this, we can always do so later.

@ikerexxe ikerexxe merged commit 2fd29cd into shadow-maint:master Sep 10, 2025
11 checks passed
@ikerexxe ikerexxe mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alejandro-colomar alejandro-colomar alejandro-colomar approved these changes

+1 more reviewer

@lslebodn lslebodn lslebodn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ikerexxe ikerexxe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ikerexxe @alejandro-colomar @lslebodn