Use available libc macros for paths, instead of creating our own. #1355
Conversation
That's the libc macro for this file. Signed-off-by: Alejandro Colomar <alx@kernel.org>
That's the libc macro for this file. Signed-off-by: Alejandro Colomar <alx@kernel.org>
ikerexxe
left a comment
ikerexxe
left a comment
There was a problem hiding this comment.
Do you know if all UNIX variants using this project contain those definitions?
I guess the only systems using this project are really musl and glibc. If all checks have passed, it means they have them. And the worst thing that could happen if someone wants to port this project to some other system where it's not available, it's that they would have a compiler error and would need to define it themselves, which is rather trivial. FWIW, I checked NetBSD and it provides them (in a different header). I assume that the other BSDs also have these macros. |
ikerexxe
left a comment
ikerexxe
left a comment
There was a problem hiding this comment.
LGTM!
I see it's in draft state so I won't merge it. Feel free to do so if you feel it's ready.
|
Ahh, I probably forgot to open it. Done. Thanks for the reminder! |
2 participants
This reduces build system code, as well as some definitions in our source code.