A couple of patches around SSSD integration #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexey-tikhonov
commented
Oct 3, 2025
alexey-tikhonov
commented
- fix a bug introduced in 59e5eef
- don't trigger useless cache flush
alexey-tikhonov
force-pushed
the
sss-cache
branch
from
91908fd to
6d7dc8b
Compare
alejandro-colomar
approved these changes
Oct 4, 2025
Collaborator
There was a problem hiding this comment.
The first commit LGTM.
I don't know the code touched in the second commit, so please @ikerexxe review that, although it also looks obviously good, but just to make sure.
Thanks!
Collaborator
|
I'm fine with the changes. @alexey-tikhonov do you mind taking into account Alejandro's concern? |
Fixes: 59e5eef (2024-07-03; "contrib, lib/, src/, tests/: Use stpcpy(3) instead of its pattern") Reviewed-by: Alejandro Colomar <alx@kernel.org>
alexey-tikhonov
force-pushed
the
sss-cache
branch
from
6d7dc8b to
325af55
Compare
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.