No news is good news #1371
Merged
No news is good news #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No news is good news. Debian needs to parse this message to ignore it, or alternatively check if the call will be a no-op (which we already do) and skip the call. If we remove this output, we're allowing Debian to remove that complexity in their wrapper. We don't expect this output to be very useful for interactive use either. Also, this message was changed from stderr to stdout recently, so we don't need to worry about old scripts that might break due to this change. If there were scripts relying on that, they would have been broken already in the previous change. Closes: <shadow-maint#1361> Reported-by: Marc Haber <githubvisible@zugschlus.de> Cc: <https://github.com/cachius> Signed-off-by: Alejandro Colomar <alx@kernel.org>
These optimizations checked if the old value is the same as the new value, and skip such changes. This was unnecessary, and added complexity to the source code. Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
no_news_is_good_news
branch
from
3329d7e to
6a8a25d
Compare
ikerexxe
approved these changes
Oct 16, 2025
Collaborator
ikerexxe
left a comment
ikerexxe
left a comment
There was a problem hiding this comment.
This PR looks good and I like how it improves maintainability by removing unnecessary complexity. My only minor concern is the performance impact (when nothing actually needs to be changed, usermod will still process everything and update files instead of short-circuiting early). That said, the benefits of simplified code and better script compatibility outweigh this trade-off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1361 (comment)
Reported-by: @Zugschlus
Cc: @cachius